Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paddle-TRT] remove engine info from RumImpl process #50181

Merged
merged 4 commits into from
Feb 8, 2023
Merged

[Paddle-TRT] remove engine info from RumImpl process #50181

merged 4 commits into from
Feb 8, 2023

Conversation

gzy19990617
Copy link
Contributor

@gzy19990617 gzy19990617 commented Feb 3, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

修复每次run engine_op的时候都会打印一次engine info,将LayerInformationFormat格式从line改为json，更易于观看；
line形式：
image
json形式：
image

@paddle-bot
Copy link

paddle-bot bot commented Feb 3, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 3, 2023
@paddle-bot
Copy link

paddle-bot bot commented Feb 3, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

gaoziyuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gzy19990617 gzy19990617 changed the title remove_engine_info remove_RunImpl_engine_info Feb 3, 2023
@gzy19990617 gzy19990617 changed the title remove_RunImpl_engine_info [Paddle-TRT] remove_RunImpl_engine_info Feb 3, 2023
zhoutianzi666
zhoutianzi666 previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@zhoutianzi666 zhoutianzi666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzy19990617 gzy19990617 closed this Feb 3, 2023
@paddle-bot
Copy link

paddle-bot bot commented Feb 3, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@gzy19990617 gzy19990617 reopened this Feb 3, 2023
@zhangjun
Copy link
Contributor

zhangjun commented Feb 3, 2023

  1. PR [Paddle-TRT] Add TensorRT inspector into Paddle-TRT #38362 添加了use_inspector_调试信息选项开关，可以在engine.cc中FreezeNetwork()和Deserialize()通过该选项控制engine info打印

zhangjun
zhangjun reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@zhangjun zhangjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tensorrt_engine_op.h中GetEngineInfo可以删除

@gzy19990617
Copy link
Contributor Author

  1. PR [Paddle-TRT] Add TensorRT inspector into Paddle-TRT #38362 添加了use_inspector_调试信息选项开关，可以在engine.cc中FreezeNetwork()和Deserialize()通过该选项控制engine info打印

已增加

zhangjun
zhangjun reviewed Feb 5, 2023
View reviewed changes
paddle/fluid/inference/tensorrt/engine.cc
@@ -828,7 +830,7 @@ void TensorRTEngine::GetEngineInfo() {
auto *infer_context = context();
infer_inspector->setExecutionContext(infer_context);
LOG(INFO) << infer_inspector->getEngineInformation(
nvinfer1::LayerInformationFormat::kONELINE);
nvinfer1::LayerInformationFormat::kJSON);
Copy link
Contributor

@zhangjun zhangjun Feb 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改成json，输出是什么形式？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前输出是一条line，不易于观看，json更易于看

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前输出是一条line，不易于观看，json更易于看

两者对比应该在PR说明里面给出来

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已补充

@zhangjun zhangjun requested a review from leo0519 February 6, 2023 05:40
@zhangjun zhangjun changed the title [Paddle-TRT] remove_RunImpl_engine_info [Paddle-TRT] remove engine info from RumImpl process Feb 6, 2023
@zhangjun
Copy link
Contributor

zhangjun commented Feb 6, 2023

Hi @leo0519 - could you take a look at this PR?

zhangjun
zhangjun approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@zhangjun zhangjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjun zhangjun merged commit b388861 into PaddlePaddle:develop Feb 8, 2023
@gzy19990617 gzy19990617 deleted the remove_engine_info branch March 6, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangjun zhangjun zhangjun approved these changes

@zhoutianzi666 zhoutianzi666 zhoutianzi666 left review comments

@leo0519 leo0519 Awaiting requested review from leo0519

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gzy19990617 @CLAassistant @zhangjun @zhoutianzi666