Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pythonlib can not be found #624

Closed
wants to merge 3 commits into from
Closed

Conversation

gangliao
Copy link
Contributor

Python_ADDITIONAL_VERSIONS can set up the python version, which required for old versions of CMake. It can be added to the front so that the specified version (2.7) could be found.

https://github.com/Kitware/CMake/blob/release/Modules/FindPythonInterp.cmake#L29

Code snippet already been validated in my laptop.

`Python_ADDITIONAL_VERSIONS` can set up the python version, which required for old versions of CMake. It can be added to the front so that the specified version (2.7) could be found.

https://github.com/Kitware/CMake/blob/release/Modules/FindPythonInterp.cmake#L29
@gangliao
Copy link
Contributor Author

我的Mac默认的是python 2.6,用这段代码是能找到python 2.7的库。

如果这个PR还不能解决问题,可以添加FAQ:

  1. 升级CMake 3.x 能解决问题
  2. 或者直接设置python 路径 cmake .. -DPYTHON_INCLUDE_DIR=xxxx -DPYTHON_LIBRARY=xxx

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 61.793% when pulling 7142ab6 on gangliao-patch-1 into 5c76b26 on release/v0.9.0.

@gangliao
Copy link
Contributor Author

#615

@gangliao gangliao added the Bug label Nov 28, 2016
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个PR并不能解决Pythonlib和PythonInterp不同的问题。

See https://asciinema.org/a/03vlit3kryre5hybw7mfr5mew

@backyes
Copy link
Contributor

backyes commented Nov 28, 2016

@gangliao

那么,感觉最彻底的解决方法, 就是把最新版本的cmake里面的FindPython这个lib挪到paddle里面来了,不知道好不好处理。

@reyoung
Copy link
Collaborator

reyoung commented Nov 28, 2016

如果不是很着急的话,这个事情可以先放一放。

因为相对而言这个事情比较简单,咱可以让Paddle外部人员贡献一下。。:-)

@reyoung
Copy link
Collaborator

reyoung commented Nov 28, 2016

我们把事情描述清楚就行了。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 61.789% when pulling bb1bd8a on gangliao-patch-1 into 5b233fa on release/v0.9.0.

@gangliao
Copy link
Contributor Author

@reyoung @backyes 那先就这样吧, 我看大家都没有直接去解决的样子。。
类似pybind issue , 也是提供FAQ

@gangliao gangliao closed this Nov 28, 2016
@gangliao gangliao deleted the gangliao-patch-1 branch November 28, 2016 11:15
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
* add launch mp distributed job

* fix comment

* update by comment
wangxicoding added a commit to wangxicoding/Paddle that referenced this pull request Dec 9, 2021
* gpt2 parallel emb

* parallel matmul

* split multi head attention

* split attention head

* split cross entropy

* fuse qkv

* update column row parallel linear

* GPT. add unittest.

Co-authored-by: WangXi <[email protected]>
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 24, 2022
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
* add dygraph prune quick_start

* add mobile deploy doc

* complete deploy doc

* add images

* fix a error;

* fix some error

Co-authored-by: gmm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants