Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve prefetch on server #9555

Merged
merged 6 commits into from
Apr 2, 2018
Merged

Improve prefetch on server #9555

merged 6 commits into from
Apr 2, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Apr 2, 2018 •
edited
Loading

project: #9211
fix: #9556

  1. fix some bugs of PrefetchVariable interface. client and server can communicate with each other using PrefetchVariable
  2. fix some code style problem of cpplint.
  3. add some more log to help debug.

@jacquesqiao jacquesqiao mentioned this pull request Apr 2, 2018
Closed
15 tasks
@typhoonzero
Copy link
Contributor

Can attach the issue to the project, so all issues can be found from the project, and remove project link from the comment.

Yancey1989
Yancey1989 approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yancey1989 Yancey1989 merged commit 09fcf5f into PaddlePaddle:develop Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve prefetch on server
3 participants
@jacquesqiao @typhoonzero @Yancey1989