Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pretrain] Fix eval during pretrain #7806

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

DesmonDay
Copy link
Contributor

@DesmonDay DesmonDay commented Jan 9, 2024

PR types

Bug fixes

PR changes

Others

Description

There might be some problems when using numpy share memory under multi-processing situation. Therefore we directly copy the data to paddle.Tensor in _collate_data func.

Copy link

paddle-bot bot commented Jan 9, 2024

Thanks for your contribution!

@DesmonDay DesmonDay requested a review from ZHUI January 9, 2024 06:15
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97f6158) 57.25% compared to head (6042b80) 57.12%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7806      +/-   ##
===========================================
- Coverage    57.25%   57.12%   -0.14%     
===========================================
  Files          585      587       +2     
  Lines        87977    88190     +213     
===========================================
+ Hits         50372    50376       +4     
- Misses       37605    37814     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI merged commit dab175b into PaddlePaddle:develop Jan 9, 2024
9 checks passed
@DesmonDay DesmonDay deleted the fix_eval_during_pretrain branch January 9, 2024 08:15
JunnYu pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants