[Bug Fix] fix allreduce tensor dtype #7876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: some CCL not support bool dtype
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7876 +/- ##
========================================
Coverage 56.67% 56.67%
========================================
Files 588 588
Lines 89243 89253 +10
========================================
+ Hits 50580 50586 +6
- Misses 38663 38667 +4 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jan 22, 2024
|
可以帮忙合入一下吗？ @wawltor |
xysheng-baidu
pushed a commit
to xysheng-baidu/PaddleNLP
that referenced
this pull request
Feb 22, 2024
* [Bug Fix] fix allreduce tensor dtype Reason: some CCL not support bool dtype * update int8 to int32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: some CCL not support bool dtype
PR types
Bug fixes
PR changes
Others
Description
update
is_resume_from_checkpointtensor dtype from bool to int8 because some CCL not support bool dtype.