[Distributed] Support pp non batch comm #8097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
SylarTiaNII
force-pushed
the
support_pp_non_batch_comm
branch
from
f206b14
to
ec038d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.7 #8097 +/- ##
============================================
Coverage 57.25% 57.25%
============================================
Files 584 584
Lines 87861 87861
============================================
Hits 50306 50306
Misses 37555 37555 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Mar 14, 2024
| @@ -971,6 +974,7 @@ def __post_init__(self): | |||
| and self.sharding_parallel_degree > 1, | |||
| "enable_timer": "enable_timer" in pipeline_parallel_config, | |||
| "release_gradients": "enable_release_grads" in pipeline_parallel_config, | |||
| "use_batch_p2p_comm": "disable_batch_p2p_comm" not in pipeline_parallel_config, | |||
There was a problem hiding this comment.
我再确定一下，这一多加一个参数，不会导致2.6.0 paddle跑 pipeline 的时候报错吧？
There was a problem hiding this comment.
不会，这个参数没有修改默认逻辑。
SylarTiaNII
added a commit
to SylarTiaNII/PaddleNLP
that referenced
this pull request
Mar 14, 2024
* add disable_non_batch_p2p_comm to pipeline_parallel_config
ZHUI
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
[Pcard-79653]
Support using non-batched communication in pipeline schedule.
To enable this function, add following param when launching scripts of PaddleNLP: