support mc2 for mp lora. #8161
Merged
support mc2 for mp lora. #8161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8161 +/- ##
===========================================
- Coverage 55.37% 55.34% -0.04%
===========================================
Files 596 597 +1
Lines 91622 91680 +58
===========================================
+ Hits 50732 50736 +4
- Misses 40890 40944 +54 ☔ View full report in Codecov by Sentry. |
lugimzzz
reviewed
Mar 21, 2024
| group=self.model_parallel_group, | ||
| use_calc_stream=True, | ||
| use_model_parallel=True, | ||
| ) |
There was a problem hiding this comment.
212到219行也有一个matmul和allreduce的过程
There was a problem hiding this comment.
这个测过，这里加fuse对性能没收益，而且会拖慢性能
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
support mc2 for mp lora.