Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainer json args-parser supports raise error #8163

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

gongel
Copy link
Member

@gongel gongel commented Mar 20, 2024

PR types

Function optimization

PR changes

APIs

Description

  • Json解析遇见不在定义中的参数时,添加报错。

Copy link

paddle-bot bot commented Mar 20, 2024

Thanks for your contribution!

@gongel gongel requested a review from ZHUI March 20, 2024 13:22
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.40%. Comparing base (b6dcb4e) to head (31d73fe).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/argparser.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8163      +/-   ##
===========================================
+ Coverage    55.37%   55.40%   +0.03%     
===========================================
  Files          596      596              
  Lines        91622    91609      -13     
===========================================
+ Hits         50732    50754      +22     
+ Misses       40890    40855      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongel gongel merged commit 4d35236 into PaddlePaddle:develop Mar 21, 2024
9 of 10 checks passed
gongel added a commit to gongel/PaddleNLP that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants