[Bug Fix]Fix merge parameters in pp #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lugimzzz
reviewed
Apr 9, 2024
| @@ -27,9 +28,33 @@ def parse_arguments(): | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument("--model_name_or_path", default=None, required=True, help="The directory of model.") | |||
| parser.add_argument("--device", type=str, default="gpu", help="Device") | |||
| parser.add_argument("--pipeline_parallel_degree", "--pp", type=int, required=True, help="pp degree") | |||
| parser.add_argument("--tensor_parallel_degree", "--tp", type=int, required=True, help="tp degree") | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8239 +/- ##
===========================================
- Coverage 55.15% 55.09% -0.06%
===========================================
Files 601 602 +1
Lines 91764 91861 +97
===========================================
+ Hits 50611 50614 +3
- Misses 41153 41247 +94 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
更新合并脚本适配pp，同时增加文件检查