fix bug for fp16 + delay_scale_loss_scale + sharding_stage1_overlap #8314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8314 +/- ##
===========================================
- Coverage 55.33% 55.33% -0.01%
===========================================
Files 614 614
Lines 95341 95342 +1
===========================================
Hits 52753 52753
- Misses 42588 42589 +1 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Apr 23, 2024
| @@ -1013,6 +1013,7 @@ def _inner_training_loop( | |||
| self.timers and self.timers("optimizer-step").start() | |||
|
|
|||
| if self.args.gradient_accumulation_steps > 1 and self._enable_delay_scale_loss(): | |||
| paddle.device.synchronize() | |||
There was a problem hiding this comment.
不会，这块必须不能有overlap。这儿需要有个同步，不然可能出现这个grad还没通讯完就做scale的问题。
ZHUI
approved these changes
Apr 23, 2024
FeixLiu
added a commit
to FeixLiu/PaddleNLP
that referenced
this pull request
Apr 24, 2024
FeixLiu
added a commit
to FeixLiu/PaddleNLP
that referenced
this pull request
Apr 24, 2024
wawltor
pushed a commit
that referenced
this pull request
Apr 24, 2024
wawltor
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
fix bug for fp16 + delay_scale_loss_scale + sharding_stage1_overlap