Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize config saving. #8490

Merged
merged 25 commits into from
Jun 14, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented May 24, 2024

PR types

New features

PR changes

optimize config

Description

optimize config

Copy link

paddle-bot bot commented May 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.41%. Comparing base (4609d07) to head (86afe4e).
Report is 248 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/configuration_utils.py 88.04% 11 Missing ⚠️
paddlenlp/transformers/qwen/modeling_pp.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8490      +/-   ##
===========================================
- Coverage    54.42%   54.41%   -0.02%     
===========================================
  Files          632      632              
  Lines        99450    99470      +20     
===========================================
- Hits         54128    54126       -2     
- Misses       45322    45344      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0844a5b into PaddlePaddle:develop Jun 14, 2024
9 of 12 checks passed
@ZHUI ZHUI deleted the feature/optimize_config branch June 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants