Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fea] moe support #8498

Merged
merged 1 commit into from
May 31, 2024
Merged

[fea] moe support #8498

merged 1 commit into from
May 31, 2024

Conversation

bo-ke
Copy link
Contributor

@bo-ke bo-ke commented May 27, 2024

PR types

PR changes

Description

Copy link

paddle-bot bot commented May 27, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kebo01 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from 0e4c89d to 55dd5a3 Compare May 28, 2024 04:37
@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from 92dbe7c to 2851da8 Compare May 28, 2024 08:45
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 2.34375% with 125 lines in your changes missing coverage. Please review.

Project coverage is 53.97%. Comparing base (0cd8fe7) to head (8894d32).
Report is 257 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 2.32% 42 Missing ⚠️
paddlenlp/trainer/utils/helper.py 2.43% 40 Missing ⚠️
paddlenlp/trainer/training_args.py 5.00% 19 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 0.00% 13 Missing ⚠️
paddlenlp/trainer/utils/reshard/common.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8498      +/-   ##
===========================================
- Coverage    54.27%   53.97%   -0.31%     
===========================================
  Files          617      618       +1     
  Lines        96356    96801     +445     
===========================================
- Hits         52302    52249      -53     
- Misses       44054    44552     +498     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bo-ke bo-ke force-pushed the develop branch 5 times, most recently from 939c0d2 to 38dfa82 Compare May 29, 2024 12:11
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
paddlenlp/trainer/training_args.py Outdated Show resolved Hide resolved
paddlenlp/trainer/utils/reshard/common.py Outdated Show resolved Hide resolved
paddlenlp/trainer/utils/helper.py Show resolved Hide resolved
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from f0cde72 to 67981e5 Compare May 30, 2024 06:58
ZHUI
ZHUI previously approved these changes May 30, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay
Copy link
Contributor

有些代码看看能不能是不是参考我这个PR的修改:#8511

@bo-ke bo-ke force-pushed the develop branch 4 times, most recently from 28e8dcc to 813c705 Compare May 30, 2024 11:03
paddlenlp/trainer/trainer.py Outdated Show resolved Hide resolved
paddlenlp/trainer/trainer.py Show resolved Hide resolved
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit ac7145d into PaddlePaddle:develop May 31, 2024
7 of 12 checks passed
bo-ke added a commit to bo-ke/PaddleNLP that referenced this pull request Jun 3, 2024
DesmonDay pushed a commit that referenced this pull request Jun 3, 2024
* [fea] moe support (#8498)

Co-authored-by: kebo01 <[email protected]>

* [fix] Broadcast optimizer state using broadcast_dp without shard-reshard. (#8522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants