Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Optimize async save #8878

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ForFishes
Copy link
Member

PR types

Performance optimization

PR changes

Others

Description

[cherry-pick] Optimize async save

Copy link

paddle-bot bot commented Aug 6, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 21.95122% with 64 lines in your changes missing coverage. Please review.

Project coverage is 55.35%. Comparing base (dbf395f) to head (32ca80e).
Report is 246 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/async_save.py 20.51% 62 Missing ⚠️
paddlenlp/trainer/trainer.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8878      +/-   ##
===========================================
+ Coverage    55.30%   55.35%   +0.04%     
===========================================
  Files          631      632       +1     
  Lines        98867    98908      +41     
===========================================
+ Hits         54681    54752      +71     
+ Misses       44186    44156      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wawltor
wawltor previously approved these changes Aug 9, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 7187299 into PaddlePaddle:develop Aug 9, 2024
9 of 12 checks passed
@ForFishes ForFishes deleted the add_async_save_in_dev branch August 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants