[Bug fix] fix skip consumed_samples twice bug #8980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8980 +/- ##
===========================================
- Coverage 54.86% 54.78% -0.08%
===========================================
Files 647 647
Lines 103342 102502 -840
===========================================
- Hits 56699 56160 -539
+ Misses 46643 46342 -301 ☔ View full report in Codecov by Sentry. |
Mangodadada
pushed a commit
to Mangodadada/PaddleNLP
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
自动并行下，从checkpoint热启时数据流错乱。因为重复跳过了在DistributedBatchSampler中已经跳过多数据。若DistributedBatchSampler中已对consumed_samples进行了处理，在trainer就不应该重复处理。