Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for pir sequence parallel on llama model #9015

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

liym27
Copy link
Contributor

@liym27 liym27 commented Aug 27, 2024

PR types

Others

PR changes

Others

Description

add test for pir sequence parallel

Copy link

paddle-bot bot commented Aug 27, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.84%. Comparing base (f6fc7ff) to head (5cd4a49).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9015      +/-   ##
===========================================
- Coverage    54.05%   53.84%   -0.21%     
===========================================
  Files          650      652       +2     
  Lines       103884   104512     +628     
===========================================
+ Hits         56155    56275     +120     
- Misses       47729    48237     +508     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhiqiu
zhiqiu previously approved these changes Aug 28, 2024
Copy link
Collaborator

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 changed the title add test for pir sequence parallel add test for pir sequence parallel on llama model Aug 29, 2024
ZHUI
ZHUI previously approved these changes Aug 29, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 29, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 29, 2024
Copy link
Collaborator

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 312d41c into PaddlePaddle:develop Aug 30, 2024
11 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants