Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eval hang #9052

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix eval hang #9052

merged 3 commits into from
Aug 29, 2024

Conversation

gongel
Copy link
Member

@gongel gongel commented Aug 29, 2024

PR types

Bug fixes

PR changes

APIs

Description

  • 当eval dataloader_num_works>0时,eval会出现hang住的情况。

Copy link

paddle-bot bot commented Aug 29, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongel gongel merged commit dc70df7 into PaddlePaddle:release/2.8 Aug 29, 2024
3 of 5 checks passed
@gongel gongel mentioned this pull request Aug 29, 2024
DesmonDay pushed a commit to DesmonDay/PaddleNLP that referenced this pull request Sep 5, 2024
* fix pipeline eval

* fix eval dataloader_num_workers
DesmonDay added a commit that referenced this pull request Sep 5, 2024
* quick fix from pretrained. (#8487)

* quick fix os.path.split (#8508)

* Cp/fix (#8569)

* [Safetensors] Fix fast safe open slice. (#8512)
* [FIX DDP] fix ddp (#8549)

* [BUG] Fix build train valid test datasets (#8823)

* Update causal_dataset.py

* Add twenty redundant data in post pretrain (#8777)

* 给dataset再添加20条数据,防止blend dataset出现错误

* num_samples向下去整,防止数据集的溢出 (#8691)

* update release_grads (#8834)

* update release_grads (#8834)

* [Trainer] Fix release_grads (#9085)

* fix pp release_grads

* add dataloader_drop_last to evaldataloader (#8773)

* bugfix

* Fix eval hang (#9052)

* fix pipeline eval

* fix eval dataloader_num_workers

---------

Co-authored-by: Zhong Hui <[email protected]>
Co-authored-by: yujun <[email protected]>
Co-authored-by: gongel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants