Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] freeze 参数冗余存储 兼容shard-reshard #9067

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bo-ke
Copy link
Contributor

@bo-ke bo-ke commented Sep 2, 2024

PR types

PR changes

Description

Copy link

paddle-bot bot commented Sep 2, 2024

Thanks for your contribution!

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (f2b3b8d) to head (e815203).
Report is 1 commits behind head on incubate/paddlenlp-fleety.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/sharding_io.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           incubate/paddlenlp-fleety    #9067      +/-   ##
=============================================================
- Coverage                      55.19%   55.19%   -0.01%     
=============================================================
  Files                            621      621              
  Lines                          96751    96752       +1     
=============================================================
  Hits                           53406    53406              
- Misses                         43345    43346       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sneaxiy sneaxiy merged commit 036c47a into PaddlePaddle:incubate/paddlenlp-fleety Sep 2, 2024
4 of 6 checks passed
bo-ke added a commit to bo-ke/PaddleNLP that referenced this pull request Sep 18, 2024
ZHUI pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants