[DCU] fix DCU w8a8c8 GEMM shape #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9115 +/- ##
===========================================
- Coverage 53.34% 53.33% -0.01%
===========================================
Files 652 652
Lines 105401 105404 +3
===========================================
Hits 56222 56222
- Misses 49179 49182 +3 ☔ View full report in Codecov by Sentry. |
yuanlehome
reviewed
Sep 10, 2024
| @@ -631,6 +631,7 @@ def __init__(self, config: LlamaConfig): | |||
| ) | |||
|
|
|||
| else: | |||
| print("self.quant_type: ", self.quant_type) | |||
YanhuiDua
commented
Sep 10, 2024
| @@ -372,7 +372,7 @@ def __init__(self, config: Qwen2Config): | |||
| use_neox_rotary_style=self.use_neox, | |||
| cachekv_int8_type=config.cachekv_int8_type, | |||
| rank_id=config.tensor_parallel_rank, | |||
| trans_qkvw=(False if paddle.is_compiled_with_rocm() and self.quant_type == "a8w8" else True), | |||
| trans_qkvw=(False if paddle.is_compiled_with_rocm() and "a8w8" in self.quant_type else True), | |||
There was a problem hiding this comment.
这个就是为了修复w8a8c8时的gemm shape ～
yuanlehome
approved these changes
Sep 10, 2024
|
|
YanhuiDua
force-pushed
the
fix_dcu_gemm
branch
from
f2f33dc
to
f5b2995
Compare
YanhuiDua
force-pushed
the
fix_dcu_gemm
branch
from
f5b2995
to
81c30d8
Compare
qingqing01
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix DCU GEMM shape when quant_type == "a8w8c8"