Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FleetY]offload optimizer state after load optmizer state #9352

Conversation

ForFishes
Copy link
Member

PR types

Bug fixes

PR changes

Others

Description

[FleetY]offload optimizer state after load optmizer state

Copy link

paddle-bot bot commented Nov 1, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.17%. Comparing base (d0d613c) to head (74bc1a0).
Report is 1 commits behind head on incubate/paddlenlp-fleety.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           incubate/paddlenlp-fleety    #9352   +/-   ##
==========================================================
  Coverage                      55.17%   55.17%           
==========================================================
  Files                            621      621           
  Lines                          96862    96868    +6     
==========================================================
+ Hits                           53443    53451    +8     
+ Misses                         43419    43417    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sneaxiy sneaxiy merged commit aa20ab2 into PaddlePaddle:incubate/paddlenlp-fleety Nov 1, 2024
5 of 7 checks passed
@ForFishes ForFishes deleted the fix_optimizer_offload branch November 4, 2024 08:08
ForFishes added a commit to ForFishes/PaddleNLP that referenced this pull request Nov 4, 2024
ForFishes added a commit to ForFishes/PaddleNLP that referenced this pull request Nov 4, 2024
wawltor pushed a commit that referenced this pull request Nov 5, 2024
* support optimizer state offload (#8715)

* support optimizer offload

* update doc

* [FleetY]offload optimizer state after load optmizer state (#9352)

* add offload optimizer

* fix memory

* [FleetY] Add reload/offload for optimizer (#9356)

* add reload/offload for optimizer

* fix bug

---------

Co-authored-by: Guoxia Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants