Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM]add ktotrainer #9393

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[LLM]add ktotrainer #9393

merged 2 commits into from
Nov 8, 2024

Conversation

lugimzzz
Copy link
Contributor

@lugimzzz lugimzzz commented Nov 7, 2024

PR types

New features

PR changes

Others

Description

新增支持KTO Trainer,开源模型适配在下一个PR

Copy link

paddle-bot bot commented Nov 7, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 10.69767% with 384 lines in your changes missing coverage. Please review.

Project coverage is 52.97%. Comparing base (140ea48) to head (280fae9).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trl/kto_trainer.py 9.96% 262 Missing ⚠️
paddlenlp/trl/kto_criterion.py 12.71% 103 Missing ⚠️
paddlenlp/transformers/tensor_parallel_utils.py 0.00% 15 Missing ⚠️
paddlenlp/trl/dpo_criterion.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9393      +/-   ##
===========================================
- Coverage    53.00%   52.97%   -0.04%     
===========================================
  Files          674      676       +2     
  Lines       107427   107838     +411     
===========================================
+ Hits         56945    57123     +178     
- Misses       50482    50715     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit b5e3f0c into PaddlePaddle:develop Nov 8, 2024
9 of 12 checks passed
@lugimzzz lugimzzz deleted the cherrykto branch November 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants