-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unittest for equation/pde/base.py #397
Merged
HydrogenSulfate
merged 6 commits into
PaddlePaddle:develop
from
jiamingkong:test_pde_basic
Jun 20, 2023
Merged
Adding unittest for equation/pde/base.py #397
HydrogenSulfate
merged 6 commits into
PaddlePaddle:develop
from
jiamingkong:test_pde_basic
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
code-style-check CI 挂了,提交之前请安装 pre-commit pip install pre-commit
pre-commit install |
Hi,感谢提醒,我已经修复了这个问题 |
覆盖率只有92%? |
可以在PR里贴上pytest 的运行结果 |
您好,应该是漏了str方法,缺了几行。现在已经修正。执行结果在该PR最早的消息上已经更新 |
HydrogenSulfate
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
* Adding unittest for equation/pde/base.py * Black code * Changed the last unit test case * pre-commit * Adding more test for 100% coverage * Black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Adding unittest for equation/pde/base.py