[Feature] Replace python funcion with sympy expression #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
changed the title
HydrogenSulfate
force-pushed
the
cvt_pyfunc_to_sym
branch
from
efaf5e4
to
be67fb4
Compare
ppsci/equation/pde/navier_stokes.py
Outdated
| def __init__(self, nu: Union[float, Callable], rho: float, dim: int, time: bool): | ||
| def __init__( | ||
| self, | ||
| nu: Union[float, Callable], |
There was a problem hiding this comment.
后面代码中 nu 允许类型为 str, 类型提示需要修改下。其他变量也检查下有没有类似情况
ppsci/equation/pde/navier_stokes.py
Outdated
| invars = (t,) + invars | ||
| if dim == 3: | ||
| invars += (z,) | ||
|
|
||
| self.nu = nu | ||
| self.rho = rho |
There was a problem hiding this comment.
这两行代码中用的的 nu, rho 在后续代码中有修改，看是否需要把这两行放到修改后面
| @@ -33,15 +35,15 @@ class Poisson(base.PDE): | |||
| >>> pde = ppsci.equation.Poisson(2) | |||
| """ | |||
|
|
|||
| def __init__(self, dim: int): | |||
| def __init__(self, dim: int, detach_keys: Optional[Tuple[str, ...]] = None): | |||
| @@ -61,214 +62,114 @@ def __init__( | |||
| rho: float = 1, | |||
| dim: int = 3, | |||
| time: bool = False, | |||
| detach_keys: Optional[Tuple[str, ...]] = None, | |||
| dim: int, | ||
| q: float, | ||
| D: float, | ||
| detach_keys: Optional[Tuple[str, ...]] = None, |
There was a problem hiding this comment.
更新docstring, 检查类型提示
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
) * add sympy2func * fix node * fix var name * fix implementation * add sympy to func module * add type hint and clean code * update unitest for N-S equation with sympy-base 'nu' * delete redundant sympy2func.py * remove sympy to function code from expression.py to sym_to_func.py * update type hint in expression * update code * update code * update code * refine sym_to_func.py * replace sympy PDE for biharmonic and laplace * refine sym_to_func.py * fix bug in _cvt_to_key * refine sym_to_func and expression code * add euler_beam static code(WIP, can not running, to be debug) * wip code * temporary code(need to be refined) * update solver code * replace more pdes with sympy * simplify code in solver * update code * rename 'normal_dot_vel' to 'normal_dot_vec' * fix bug * update unitest * remove redundant unitest * remove unnecessary code * remove unnecessary more code * use DETACH_FUNC_NAME instead of 'detach' * add derivatives for sdf function * replace .diff.diff with .diff(, 2) * support exporting expression to .dot and .png file for visualizing and DEBUG * remove compute_sdf_derivatives for next PR * refine docstring of ppsci/data/dataset/array_dataset.py * remove sdf_derivatives code in geometry for next PR * remove print code in solver * rename sympy_to_function to lambdify and add it in ppsci.* * rename for test files * rename sym_to_func.py to symbolic.py * update linear_init_ and conv_init_ to kaiming style * refine probability document * change list to tuple * update docstrings of equations * larger atol to 1e-7 for test_linear_elasticity * fix seed to 42 for test_linear_elasticity --------- Co-authored-by: PuQing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
主要修改点：
Solver和expression其他：
normal_dot_vel为normal_dot_vecsp_parser的相关无用代码