GCNGalerkin+PINO论文复现 #566

zlynna · 2023-10-11T07:22:12Z

PR types

Others

PR changes

Others

Describe

论文题目：
Physics-informed graph neural Galerkin networks: A unified framework for solving PDE-governed forward and inverse problems

paddle-bot · 2023-10-11T07:22:18Z

Thanks for your contribution!

paddle-bot · 2023-10-11T07:22:21Z

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

CLAassistant · 2023-10-11T07:22:23Z

All committers have signed the CLA.

wangguan1995

to fix

docs/images/deephpms/burgers_diff_lbfgs.png

modelCircleDet.npy

jointContribution/graphGalerkin/demo1/grad.txt

jointContribution/graphGalerkin/demo1/init.pdparams

jointContribution/graphGalerkin/demo1/param.txt

jointContribution/graphGalerkin/demo0/result/Demo.pdf

jointContribution/graphGalerkin/demo0/result/ErFinal.txt

jointContribution/graphGalerkin/demo0/result/Loss.txt

jointContribution/graphGalerkin/demo0/result/LossResidual.png

jointContribution/graphGalerkin/demo0/result/Demo.pdf

lijialin03 · 2023-10-17T11:36:48Z

重新拉一下paddlescience develop，不要拉我fork的仓库里的，现在的版本不对，多了很多随着版本更新删掉的文件。可以改一下git远程仓库地址。
用 pre-commit 修正一下格式。
即使在同一个文件中，也把文件中不同功能的部分写成函数封装一下，比如训练部分写在main函数里，把画图部分单独写成函数并添加必要注释如 type hint（参考ppsci文件夹下的代码书写格式）。
尽量复用代码，如同一个demo下只是更换了结构/公式等，这也是上一条中对不同功能的代码进行封装的原因。

另外如果review的改完了，可以点一下resolved

jointContribution/graphGalerkin/demo0/DiskPossionHard.py

lijialin03 · 2023-10-17T11:53:34Z

jointContribution/graphGalerkin/rfcs/graphGalerkin.md

+# 3. 业内方案调研
+## 3.1 解决的问题
+本项目基于嵌入物理信息的图神经网络求解偏微分方程，方程主要以以下形式出现：
+$$ \nabla \cdot F(u, \nabla u; \boldsymbol\mu) = S(u, \nabla u; \boldsymbol\mu) \: in \:  \Omega $$


公式没有正常显示，点击

jointContribution/graphGalerkin/rfcs/graphGalerkin.md

lijialin03 · 2023-10-25T11:04:05Z

删除多余文件

wangguan1995

delete useless files

jointContribution/PINO/PINO_paddle/scripts/device1-finetune.sh

jointContribution/PINO/PINO_paddle/Dockerfile

jointContribution/PINO/PINO_paddle/models/fourier1d.py

wangguan1995 · 2023-10-27T11:52:20Z

jointContribution/PINO/PINO_paddle/models/fourier2d.py

我理解，没用到2d.py

2d.py和3d.py都被用到了

jointContribution/PINO/PINO_paddle/configs/finetune/Darcy-finetune.yaml

jointContribution/PINO/PINO_paddle/.gitignore

jointContribution/PINO/PINO_paddle/.dockerignore

jointContribution/graphGalerkin/utils/GCNConv.py

jointContribution/graphGalerkin/utils/helpers.py

jointContribution/graphGalerkin/source/GCNNModel.py

lijialin03 · 2023-10-29T15:29:25Z

辛苦大佬提交代码～
麻烦检查一下：

代码是否存在没有用到/不必要的部分和文件！是否可以不进行某些封装！
注释中是否存在问题，如废弃代码/中文注释/不恰当用词等
是否存在不正确的API，如paddle中不存在的API
代码是否简洁，如需要避免重复/冗余/废弃/嵌套过多的代码，尽量只保留必要代码
下面CI也有报错，需要检查一下代码中的问题
谢谢

lijialin03

现在是能跑通的吗……？

而且看下面流水线检查里的"code-style-check"，一直都有错误，可以点开检查一下
以及删掉一些代码之后，比如TestNet已经找不到了，但是它依然写在import代码里
以及import的一些函数并没有被用到，比如灰色的这些

先整体检查一下，最起码代码需要跑通呀
另外，可以把这两个案例分开提一下pr，不然它俩都动不了

lijialin03 · 2023-11-03T07:48:57Z

jointContribution/graphGalerkin/demo0/DiskPossionHard.py

+paddle.seed(1334)
+from random import sample 
+
+sys.path.insert(0, 'pycamotk')


这个文件放demo0下面之后，这样添加路径是调不到pycamotk的

lijialin03 · 2023-11-03T07:49:05Z

jointContribution/graphGalerkin/demo0/DiskPossionHard.py

+from pyCaMOtk.solve_fem import solve_fem
+from pyCaMOtk.visualize_fem import visualize_fem
+
+sys.path.insert(0, 'source')


wangguan1995 · 2023-11-03T09:19:28Z

现在是能跑通的吗……？而且看下面流水线检查里的"code-style-check"，一直都有错误，可以点开检查一下以及删掉一些代码之后，比如TestNet已经找不到了，但是它依然写在import代码里以及import的一些函数并没有被用到，比如灰色的这些先整体检查一下，最起码代码需要跑通呀另外，可以把这两个案例分开提一下pr，不然它俩都动不了

可能是没有安装 pre-commit导致
参考 https://paddlescience-docs.readthedocs.io/zh/latest/zh/development/#41-pre-commit

luotao1 · 2023-11-08T10:45:04Z

hi, @zlynna

非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
如果你对PFCC有兴趣，请发送邮件至 [email protected]，我们会邀请你加入~

* add submodule as a git submodule * pre commit * change the md file * md file * review * delete useless file * delete useless file * change the files according to the review * change graphGalerkin * change graphGalerkin * graphGalerkin * update1 --------- Co-authored-by: lijialin03 <[email protected]>

paddle-bot bot added the contributor label Oct 11, 2023

wangguan1995 reviewed Oct 11, 2023

View reviewed changes

luotao1 assigned luotao1 and wangguan1995 Oct 16, 2023

lijialin03 reviewed Oct 17, 2023

View reviewed changes

zlynna force-pushed the develop branch from e9b0d9a to b624b89 Compare October 17, 2023 19:05

wangguan1995 reviewed Oct 27, 2023

View reviewed changes

lijialin03 reviewed Oct 29, 2023

View reviewed changes

lijialin03 reviewed Nov 3, 2023

View reviewed changes

zlynna added 11 commits November 8, 2023 06:55

add submodule as a git submodule

3c5d0fd

pre commit

6139c5c

change the md file

0e50b4a

md file

d2891eb

review

212c5d1

delete useless file

b81cc44

delete useless file

3d7b963

change the files according to the review

0f9d00a

change graphGalerkin

48f9c7b

change graphGalerkin

8037e10

graphGalerkin

dd153c6

lijialin03 force-pushed the develop branch from a8c23e1 to ad2c546 Compare November 8, 2023 09:04

lijialin03 approved these changes Nov 8, 2023

View reviewed changes

lijialin03 force-pushed the develop branch from ad2c546 to 5243c32 Compare November 8, 2023 10:09

update1

42f67cc

lijialin03 force-pushed the develop branch from 5243c32 to 42f67cc Compare November 8, 2023 10:10

HydrogenSulfate approved these changes Nov 8, 2023

View reviewed changes

HydrogenSulfate merged commit 014218a into PaddlePaddle:develop Nov 8, 2023
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GCNGalerkin+PINO论文复现 #566

GCNGalerkin+PINO论文复现 #566

zlynna commented Oct 11, 2023 •

edited

Loading

paddle-bot bot commented Oct 11, 2023

paddle-bot bot commented Oct 11, 2023

CLAassistant commented Oct 11, 2023 •

edited

Loading

wangguan1995 left a comment

lijialin03 commented Oct 17, 2023 •

edited

Loading

lijialin03 Oct 17, 2023

lijialin03 commented Oct 25, 2023

wangguan1995 left a comment

wangguan1995 Oct 27, 2023

zlynna Oct 29, 2023

lijialin03 commented Oct 29, 2023 •

edited

Loading

lijialin03 left a comment •

edited

Loading

lijialin03 Nov 3, 2023

lijialin03 Nov 3, 2023

wangguan1995 commented Nov 3, 2023

luotao1 commented Nov 8, 2023

GCNGalerkin+PINO论文复现 #566

GCNGalerkin+PINO论文复现 #566

Conversation

zlynna commented Oct 11, 2023 • edited Loading

PR types

PR changes

Describe

paddle-bot bot commented Oct 11, 2023

paddle-bot bot commented Oct 11, 2023

CLAassistant commented Oct 11, 2023 • edited Loading

wangguan1995 left a comment

Choose a reason for hiding this comment

lijialin03 commented Oct 17, 2023 • edited Loading

lijialin03 Oct 17, 2023

Choose a reason for hiding this comment

lijialin03 commented Oct 25, 2023

wangguan1995 left a comment

Choose a reason for hiding this comment

wangguan1995 Oct 27, 2023

Choose a reason for hiding this comment

zlynna Oct 29, 2023

Choose a reason for hiding this comment

lijialin03 commented Oct 29, 2023 • edited Loading

lijialin03 left a comment • edited Loading

Choose a reason for hiding this comment

lijialin03 Nov 3, 2023

Choose a reason for hiding this comment

lijialin03 Nov 3, 2023

Choose a reason for hiding this comment

wangguan1995 commented Nov 3, 2023

luotao1 commented Nov 8, 2023

zlynna commented Oct 11, 2023 •

edited

Loading

CLAassistant commented Oct 11, 2023 •

edited

Loading

lijialin03 commented Oct 17, 2023 •

edited

Loading

lijialin03 commented Oct 29, 2023 •

edited

Loading

lijialin03 left a comment •

edited

Loading