update PhyGeoNet #731
Merged
update PhyGeoNet #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
requested changes
Jan 1, 2024
There was a problem hiding this comment.
code部分形如：XXX = cfg.xxx的冗余代码可以都优化一下，直接用cfg.xxx即可
examples/phygeonet/heat_equation.py
Outdated
| "iters_per_epoch": iters_per_epoch, | ||
| "num_workers": 0, | ||
| }, | ||
| ppsci.loss.FunctionalLoss(lambda out, label, weught: out["mRes"]), |
examples/phygeonet/heat_equation.py
Outdated
| ) | ||
| sup_constraint = {sup_constraint_mres.name: sup_constraint_mres} | ||
|
|
||
| def _transform_out(_input, _output, pad_singleside=pad_singleside): |
There was a problem hiding this comment.
加一下type-hint以及docstring
examples/phygeonet/heat_equation.py
Outdated
Comment on lines
8
to
11
| from utils import dfdx | ||
| from utils import dfdy | ||
| from utils import setAxisLabel | ||
| from utils import visualize |
There was a problem hiding this comment.
改为import util+utils.xxx的调用方式
examples/phygeonet/heat_equation.py
Outdated
|
|
||
| def _transform_out(_input, _output, pad_singleside=pad_singleside): | ||
| output_v = _output["outputV"] | ||
| Jinv = _input["jinvs"] |
examples/phygeonet/utils.py
Outdated
| return dfdx | ||
|
|
||
|
|
||
| def dfdy(f, dxdxi, dxdeta, Jinv, h=0.01): |
examples/phygeonet/utils.py
Outdated
| return dfdy | ||
|
|
||
|
|
||
| def setAxisLabel(ax, type): |
There was a problem hiding this comment.
函数名使用小写，并用单下划线分隔单词
examples/phygeonet/utils.py
Outdated
| raise ValueError("The axis type only can be reference or physical") | ||
|
|
||
|
|
||
| def gen_e2vcg(x): |
There was a problem hiding this comment.
e2vcg意义不明，在docstring中补上说明
examples/phygeonet/utils.py
Outdated
| return ax, cbar | ||
|
|
||
|
|
||
| def tikzplotlib_fix_ncols(obj): |
examples/phygeonet/utils.py
Outdated
| e2vcg[:, j * nelemx + i] = np.asarray( | ||
| [j * nnx + i, j * nnx + i + 1, (j + 1) * nnx + i, (j + 1) * nnx + i + 1] | ||
| ) | ||
| return e2vcg.astype("int") |
|
@HydrogenSulfate done |
HydrogenSulfate
requested changes
Jan 3, 2024
examples/phygeonet/heat_equation.py
Outdated
Comment on lines
16
to
18
| # initiallizer | ||
| ppsci.utils.misc.set_random_seed(cfg.seed) | ||
| logger.init_logger("ppsci", osp.join(cfg.output_dir, "train.log"), "info") |
There was a problem hiding this comment.
examples/phygeonet/heat_equation.py
Outdated
Comment on lines
100
to
102
| logger.init_logger("ppsci", osp.join(cfg.output_dir, "eval.log"), "info") | ||
| ppsci.utils.misc.set_random_seed(cfg.seed) | ||
|
|
|
@HydrogenSulfate done |
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
* Change the directory structure * update phygeonet code * update heat equation code * update heat equation with bc code * refine phygeonet code * add callback for seed and logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
更新PhyGeoNet案例代码
TODO：更新案例文档