Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix fuse derivative corner case and add UT #748

Merged

Conversation

HydrogenSulfate
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate commented Jan 11, 2024

PR types

Bug fixes

PR changes

APIs

Describe

  1. 添加 fuse_derivative 单测以及修复某些corner case会导致一直在合并结点的情况
  2. 优化 jacobian 对多输入变量求解判断,跳过已缓存的结果

Copy link

paddle-bot bot commented Jan 11, 2024

Thanks for your contribution!

@zhiminzhang0830
Copy link
Collaborator

LGTM

@zhiminzhang0830 zhiminzhang0830 merged commit 14ff0ac into PaddlePaddle:develop Jan 11, 2024
3 checks passed
@HydrogenSulfate HydrogenSulfate deleted the fix_fuse_grad_case branch January 12, 2024 01:58
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* fix coner case for FusedDerivativeNode is placed at the end of nodes group

* add UT for fuse derivatives

* fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants