[Enh] add validation for hydra config #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
force-pushed
the
add_config_validation
branch
from
b325f8d
to
5f4c716
Compare
ppsci/utils/config.py
Outdated
| def log_freq_check(cls, v): | ||
| if not isinstance(v, int): | ||
| raise ValueError( | ||
| "'log_freq' should be a int" f", but got {misc.typename(v)}" |
ppsci/utils/config.py
Outdated
| ) | ||
| if not isinstance(info.data["wandb_config"], dict): | ||
| raise ValueError( | ||
| f"'wandb_config' should be a dict when 'use_wandb' is True, " |
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
* add validation for hydra config * update unitest for pydantic * fix for OptimizerList * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
内容主要来自 #737 的部分commit，完成 #233 (review) 的TODO