[Add]MRMSDataset #810
Merged
[Add]MRMSDataset #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
requested changes
Mar 19, 2024
ppsci/data/dataset/mrms_dataset.py
Outdated
| def __getitem__(self, global_idx): | ||
| _samples = [] | ||
| for idx in range(global_idx, global_idx + self.num_total_timestamps): | ||
| _samples.append(np.expand_dims(self.files[idx]["dataset"],axis=0)) |
There was a problem hiding this comment.
这里直接固定为"dataset"，不需要像另一个class一样传一个var？
ppsci/data/dataset/mrms_dataset.py
Outdated
| input_item = {self.input_keys[0]: np.concatenate(_samples, axis=0).astype(paddle.get_default_dtype())} | ||
| label_item = {} | ||
| for key in self.label_keys: | ||
| label_item[key] = np.asarray([], paddle.get_default_dtype()) |
There was a problem hiding this comment.
np.asarray([], paddle.get_default_dtype())构造一个0-size数组作用是什么呢
There was a problem hiding this comment.
本来是想保留一下key，但是感觉也没必要，已删除
|
PR提交前先安装pre-commit，否则code-style-check无法通过 |
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
* [Add]MRMSDataset * fix code and style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe