-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enh] Refactor sum aggregator #834
Merged
zhiminzhang0830
merged 10 commits into
PaddlePaddle:develop
from
HydrogenSulfate:refactor_sum_agg
Apr 7, 2024
Merged
[Enh] Refactor sum aggregator #834
zhiminzhang0830
merged 10 commits into
PaddlePaddle:develop
from
HydrogenSulfate:refactor_sum_agg
Apr 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PCGrad when used with amp
Thanks for your contribution! |
HydrogenSulfate
changed the title
[Refine] Refactor sum agg
[Enh] Refactor sum aggregator
Apr 7, 2024
zhiminzhang0830
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
huohuohuohuohuo123
pushed a commit
to huohuohuohuohuo123/PaddleScience
that referenced
this pull request
Aug 12, 2024
* add Sum loss aggregator * simplify loss aggregation code in train.py and add check for AGDA and PCGrad when used with amp * add check for using L-BFGS with use_amp=True * Refine Relobralo * Fix docstring of timedomain.py * remove unnecessary code in train.py * automatically download *.pdeqn file if available when download pretrained model * wrap func generated by symbolic module with DDP * fix Relobralo * initialize loss with 0.0 instead of first loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
mtl.Sum
类,并将默认总loss计算逻辑移动至该类中,简化train.py
的代码;mtl
下部分类的类型注解;Solver
添加对LBFGS
优化器、mtl
部分类与自动混合精度之间的兼容性检查;timedomain.py
内的string
类型改为str
;dist_wrapper
补充对symbolic module转换后的含参函数模型进行包装;load_pretrain
函数支持自动下载*.pdeqn
文件,如viv案例无需再手动下载文件。