Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Add ldc 2d Re1000 and Re3200 example #924

Merged

Conversation

HydrogenSulfate
Copy link
Collaborator

PR types

New features

PR changes

Others

Describe

  1. 添加 Re1000 和 Re3200 的 LDC 案例和文档(替换原有的 LDC2d_steady 内容)
  2. 修复多处 docstring 开头未大写的问题,删除多余换行,添加缺少的换行

Copy link

paddle-bot bot commented Jun 11, 2024

Thanks for your contribution!

@@ -468,7 +494,7 @@ def forward_tensor(self, x):
for i, linear in enumerate(self.linears):
y = linear(y)
y = self.acts[i](y)
y = (1 - y) * u + y * v
y = y * u + (1 - y) * v
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样修改后对之前的案例的权重文件还兼容么

Copy link
Collaborator Author

@HydrogenSulfate HydrogenSulfate Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前没有案例使用这个Modifield_MLPPirateNet的BUG修复后,会影响AllenCahn案例,所以已经重训了AllenCahn模型,精度跟原论文保持一致,我在bce上已经更新了权重文件和结果图。

@@ -119,5 +134,6 @@ def __call__(
self.weight[i].set_value(
self.momentum * self.weight[i] + (1 - self.momentum) * weight[i]
)
# logger.message(f"weight at step {self.step}: {self.weight.numpy()}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥需要注释掉?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉默认情况下可能不太需要打印?

Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiminzhang0830 zhiminzhang0830 merged commit fc1945d into PaddlePaddle:develop Jun 12, 2024
3 of 4 checks passed
@HydrogenSulfate HydrogenSulfate deleted the add_ldc_2d_Re1000_plain branch June 12, 2024 02:41
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* update piranet for ldc re3200 case(WIP)

* add ldc_2d_Re1000 plain example

* add ldc_2d_Re3200_piratenet and ldc_2d_Re3200_sota

* refine code

* refine docstrings

* add missing blank line for docstrings

* refine docstrings

* replace lowercase to uppercase for first word in sentence

* add ldc_2d_re3200_piratenet and ldc_2d_re3200_sota

* remove redundant files

* fix linenum

* fix doctest

* fix for allen_cahn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants