Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add program caching #741

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Add program caching #741

merged 1 commit into from
Mar 19, 2018

Conversation

panyx0718
Copy link
Contributor

Reduce step time from 0.2 to 0.15

transform

@panyx0718
Add program caching
82ed838 
Reduce step time from 0.2 to 0.15
guoshengCS
guoshengCS approved these changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@guoshengCS guoshengCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. One question about program_cache is should it be better that the dict program_cache belongs to program rather than executor.

@panyx0718
Copy link
Contributor Author

Maybe. Or it should belong to something else.

@panyx0718 panyx0718 merged commit c7a1c88 into PaddlePaddle:develop Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshengCS guoshengCS guoshengCS approved these changes

@pkuyym pkuyym Awaiting requested review from pkuyym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panyx0718 @guoshengCS