Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not match code #16

Closed
Luzifer opened this issue Aug 3, 2016 · 2 comments
Closed

Documentation does not match code #16

Luzifer opened this issue Aug 3, 2016 · 2 comments

Comments

@Luzifer
Copy link

Luzifer commented Aug 3, 2016

The README and repository description states this is a library using your v2 API. Taking a look into the client.go it uses the v1 endpoint so this is in fact not a v2 library…

Also for example CreateOverride does send invalid data according to the specification of the v2 API documentation. Even when patching the data the response code handling is broken…

Please label this as an v1 library or port it to v2.

@dthagard
Copy link
Contributor

dthagard commented Sep 3, 2016

I've overhauled the SDK to work correctly with V2 in this PR: #23

@ranjib
Copy link
Contributor

ranjib commented Sep 6, 2016

@Luzifer as @dthagard the library now has v2 api. I had made some fixes soon after you raise the issue, as well. Let us know if you think its still not matching the v2 API. This is under active development, and not quiet ready yet (does not cover the entire API).

@ranjib ranjib closed this as completed Sep 6, 2016
mLupine pushed a commit to mLupine/go-pagerduty that referenced this issue May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants