Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContactMethods operations #169

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Add ContactMethods operations #169

merged 1 commit into from
Feb 5, 2020

Conversation

timlittle
Copy link
Contributor

@timlittle timlittle commented Sep 17, 2019 •
edited
Loading

  • Adding ContactMethod API operations to the library.
  • Update Golang container in circleCI to resolve import issues

apidoc:
https://api-reference.pagerduty.com/#!/Users/post_users_id_contact_methods

Issue: #125

@timlittle timlittle requested a review from dobs January 29, 2020 16:52
stmcallister
stmcallister approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for submitting this! I made a minor tweak on the CreateUserContactMethod function to keep things consistent. Also added tests for each of the functions. Will merge this PR with a few others soon.

@stmcallister stmcallister mentioned this pull request Feb 5, 2020
Merged
@stmcallister stmcallister merged commit 1ea5043 into PagerDuty:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

@dobs dobs Awaiting requested review from dobs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timlittle @stmcallister