Modify ListOverrides and add ListOverridesResponse #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcallister
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Verified that ListOverrides was broken and this PR fixed it. Thank you for your contribution to the project, @dstevensio !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I repeatedly encountered an error when using ListOverrides as the response from PagerDuty's API could not be correctly marshaled to
[]PagerDuty.OverrideThis PR changes the behavior of ListOverrides so that it follows the pattern used by ListSchedules and as a result, allows proper operation of the endpoint.
This is a breaking change in as much as it changes the type returned by the method, but in my testing at least, the current implementation is broken itself.
Fixes #180