Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teams to Schedule #208

Merged
merged 1 commit into from
May 14, 2020
Merged

Add Teams to Schedule #208

merged 1 commit into from
May 14, 2020

Conversation

miekg
Copy link
Contributor

@miekg miekg commented Mar 3, 2020

Nor the API docs, nor the current code says so, but Schedule can take a
team (or more than one). Add this by using an APIReference slice.

Signed-off-by: Miek Gieben [email protected]

Nor the API docs, nor the current code says so, but Schedule can take a
team (or more than one). Add this by using an APIReference slice.

Signed-off-by: Miek Gieben <[email protected]>
@stmcallister
Copy link
Contributor

Thanks for the PR @miekg ! As a rule, we're only including documented features in our code libraries. That said, your PR gave me the avenue to poke our engineering team to add this to the docs! :) When the docs are updated I will merge. Thanks!

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs now list teams on the schedule object, and this looks good. Thanks for the contribution!!

@stmcallister stmcallister merged commit 0aa3df3 into PagerDuty:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants