Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List incident alerts #214

Merged
merged 4 commits into from
May 15, 2020
Merged

List incident alerts #214

merged 4 commits into from
May 15, 2020

Conversation

kilianw
Copy link
Contributor

@kilianw kilianw commented Apr 9, 2020

Add query options to the 'List alerts for an incident' - /incidents/{id}/alerts

@stmcallister
Copy link
Contributor

@kilianw - Thanks for making this contribution! Adding ListIncidentAlertsOptions will certainly add values to users. However, adding the additional argument to the ListIncidentAlerts function will break that call for existing users of the function.

How about we create a ListIncidentAlertsWithOpts function so that we remain backwards compatible? We could even have ListIncidentAlerts call the new options function to avoid duplicate code.

stmcallister
stmcallister approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you!

@stmcallister stmcallister merged commit d8a84d2 into PagerDuty:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilianw @stmcallister