Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UpdateService #220

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix UpdateService #220

merged 1 commit into from
May 8, 2020

Conversation

angpalm
Copy link
Contributor

@angpalm angpalm commented May 8, 2020

Fixes #188

JSON body must be nested under service key on service update to be recognized.

stmcallister
stmcallister approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for finding this and submitting a fix!

@stmcallister stmcallister merged commit 03fbf44 into PagerDuty:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service: SupportHours creation not supported
2 participants
@angpalm @stmcallister