Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FirstTriggerLogEntry and CommonLogEntryField fields and json tags #230

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

afarbos
Copy link
Contributor

@afarbos afarbos commented Jun 17, 2020

first_trigger_log_entry contain way more than just an APIObject.
This PR intend to add all fields that are (un)marshall from the first_trigger_log_entry

@afarbos
Copy link
Contributor Author

afarbos commented Jun 23, 2020

@stmcallister if you have a chance to look at this PR.
Thanks,

@stmcallister
Copy link
Contributor

stmcallister commented Jun 23, 2020

@afarbos Thanks for making this contribution! However, I'm not able to get additional fields to come back on the first_trigger_log_entry object on the incidents endpoint. Using POSTMAN I only see id, type, summary, self and html_url (essentially, just the APIObject fields. Can you share how you're getting the additional fields?

@afarbos
Copy link
Contributor Author

afarbos commented Jun 24, 2020

Did you include first_trigger_log_entries? see the original request:

{
  "method": "get",
  "url": "https://api.pagerduty.com/incidents",
  "query": {
    "include[]": "first_trigger_log_entries"
  },
  "headers": {
    "Accept": "application/vnd.pagerduty+json;version=2",
    "Authorization": "Token token=*********************"
  }
}

You could also use pd from this repo like this:

make build && ./pd incident list --include first_trigger_log_entries

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this!

@stmcallister stmcallister merged commit e8ee333 into PagerDuty:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants