Adding Get Incident Alert and Manage Incident Alert endpoints #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobs
approved these changes
Jun 26, 2020
incident.go
Outdated
| Acknowledgements []Acknowledgement `json:"acknowledgements,omitempty"` | ||
| LastStatusChangeAt string `json:"last_status_change_at,omitempty"` | ||
| LastStatusChangeBy APIObject `json:"last_status_change_by,omitempty"` | ||
| FirstTriggerLogEntry FirstTriggerLogEntry `json:"first_trigger_log_entry,omitempty"` |
There was a problem hiding this comment.
Looks like we're no longer using the FirstTriggerLogEntry struct after this change -- might want to remove? It's publicly accessible but put particularly useful at this point.
There was a problem hiding this comment.
Actually, we should be using that. Looks like I removed it by mistake. Will restore.
Comment on lines
-396
to
-408
| type Alert struct { | ||
| APIObject | ||
| Service APIObject `json:"service,omitempty"` | ||
| CreatedAt string `json:"created_at,omitempty"` | ||
| Status string `json:"status,omitempty"` | ||
| AlertKey string `json:"alert_key,omitempty"` | ||
| Incident APIObject `json:"incident,omitempty"` | ||
| } | ||
|
|
||
| type ListAlertResponse struct { | ||
| APIListObject | ||
| Alerts []Alert `json:"alerts,omitempty"` | ||
| } |
There was a problem hiding this comment.
Similarly here -- guessing impact is low if these aren't referenced anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results for all the incident tests since I also added ConferenceBridge to the Incident object.