fix misspelling in trigger_summary_data's JSON key. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @tomwans |
mLupine
pushed a commit
to mLupine/go-pagerduty
that referenced
this pull request
May 27, 2020
* Makefile: Update tools and targets (PagerDuty#1) * Makefile: Update tools and targets Remove `gosimple` and `unused` tools and targets as they are now integrated into `staticcheck` * CI: Update go version in CI from 1.10.1 to 1.12.4 * CI: Set GO111MODULE=off until support for Go modules is enabled * Makefile: Update path for staticcheck tools * Support attributes `alert_grouping` and `alert_grouping_timeout` in the service resource (PagerDuty#2) * Makefile: Update tools and targets Remove `gosimple` and `unused` tools and targets as they are now integrated into `staticcheck` * CI: Update go version in CI from 1.10.1 to 1.12.4 * CI: Set GO111MODULE=off until support for Go modules is enabled * Makefile: Update path for staticcheck tools * services: Add `alert_grouping` and `alert_grouping_timeout` to Service The current test for List endpoints was not testing all fields, so this commit creates test fixtures from sample data taken from the Pagerduty API explorer to verify the fields for a service. And it also add the fields for `alert_grouping` and `alert_grouping_timeout`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple misspelling that I caught while reading the documentation.