Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the formatting of the ResponderRequest input and output #442

Closed

Conversation

CerealBoy
Copy link
Contributor

The documentation has 2 different ways to structure this code, where the doc and the example are different. Previously the code here had worked with the doc formatting, however this is currently not working as intended.

The main change here is within the responder_request_targets portion of the payload, where the array content is an object that then contains a key responder_request_target with the actual object, rather than just this object itself. i.e. It's nested one key deeper in the tree. Originally I'd thought this was different for the input and the output, turns out the only difference is that the incident_responders is not provided in the input, and populated in the output.

This PR also includes the 3 line change to update the go.* files as this was tested on an M1 mac, so a newer version of the golang.org/x/sys library is needed that supports arm64.

@ChuckCrawford
Copy link
Collaborator

Apologies for not getting to this earlier but it looks like we have resolved these issues as part of #452 and #434.

Feel free to reopen this if there are still issues in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants