Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule restriction - Add support for start_day_of_week #52

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Schedule restriction - Add support for start_day_of_week #52

merged 1 commit into from
Dec 16, 2016

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Nov 12, 2016

Hi,

this adds support for start_day_of_week.
Without start_day_of_week set, a restriction with type weekly_restriction will fail with:

Failed call API endpoint. HTTP response code: 400. Error: &{2001 Invalid Input Provided [Start day of week must be in 1, 2, 3, 4, 5, 6, 7, 1, 2, 3, 4, 5, 6, or 7.]}

@heimweh
Copy link
Contributor Author

heimweh commented Nov 23, 2016

Hi @ranjib. Would you be able to take a look at this one? 🙂 Not sure if I missed something.

@blalor
Copy link

blalor commented Dec 3, 2016

Bump; would love to see this make it into Terraform (and made available to other users of the library).

@fmasuhr
Copy link

fmasuhr commented Dec 9, 2016

@ranjib I would also like to see this merged to use this via terraform :)

@paultyng
Copy link

paultyng commented Dec 16, 2016

Interestingly the field is missing in the online docs as well:

https://v2.developer.pagerduty.com/v2/page/api-reference#!/Schedules/post_schedules

@evan2645
Copy link
Contributor

Thank you for this, and very sorry for the delay.

Also thanks for pointing out that this option is missing in the docs @paultyng we have filed an internal ticket to get that fixed up

@evan2645 evan2645 merged commit b98d93d into PagerDuty:master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants