Fixing Maintenance typo #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also turns out that the URLs were returning 404 for a number of maintenance window functions as well:
All had |
|
Cor, this looks useful. |
|
What do we need to do to get this merged? I'm running into the same issue. Perhaps we could disregard the method signature changes and just update the endpoint to prevent breaking changes? I just submitted a PR fixing the same thing, but then found this issue. |
|
Thanks for the contribution here and it LGTM! After taking a look at the code I don't think there will actually be any breaking changes to the library as the methods that were updated were already broken. Truly functioning client code using this library should not be affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously
CreateMaintaienanceWindows, changed toCreateMaintenanceWindows, however this is a breaking API change if users are accessing the typo version.