Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for escalation rules #71

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Add support for escalation rules #71

merged 1 commit into from
Mar 17, 2017

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Mar 15, 2017 •
edited
Loading

This PR adds support for managing escalation rules in an escalation policy.

Added:

  • Create escalation rule
  • Get escalation rule
  • Update escalation rule
  • Delete escalation rule
  • List escalation rules

For more information see: https://v2.developer.pagerduty.com/v2/page/api-reference#!/Escalation_Policies/post_escalation_policies_id_escalation_rules

@heimweh
Copy link
Contributor Author

heimweh commented Mar 15, 2017

@lfepp would you mind taking a look at this? :)

All functions have been tested and seems to work, just not sure if I've missed something.

@lfepp lfepp self-requested a review March 16, 2017 03:55
lfepp
lfepp approved these changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@lfepp lfepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfepp lfepp merged commit 63a6e47 into PagerDuty:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfepp lfepp lfepp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heimweh @lfepp