Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document parallel evm funnel delay/confirmationDepth #39

Merged
merged 4 commits into from
May 29, 2024

Conversation

ecioppettini
Copy link
Contributor

@ecioppettini ecioppettini self-assigned this May 7, 2024
Comment on lines 52 to 53
This has the effect that no events newer than `current time - delay` will be
processed by the funnel (relative to the main chain's latest synced block).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably explain when to use this vs confirmationDepth (possibly in a common document referenced by multiple funnels like some kind of new meta category for funnel types in the docs that talks about funnel concepts in general as opposed to concrete funnels)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but first I guess we may also want to change the carp's funnel config, since now it's different than these (it doesn't have delay).

But it's not really a vs thing I believe. In general I would choose the confirmation parameter and then choose the delay accordingly so that it makes progress without waiting for block production all the time. Technically you can set only a delay, but I'm not sure there is actually a use-case for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a ping that we still need to do something about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some refactoring and added a page for parallel funnels, which now encompasses all of the funnels that synchronize other chains. I think the term is probably generic enough. And also moved a big chunk of the common sections there, including the diagrams. And then I also added some guidelines for the usage of delay and confirmationDepth.

@SebastienGllmt SebastienGllmt merged commit 86e99e1 into main May 29, 2024
1 check passed
@SebastienGllmt SebastienGllmt deleted the enzo/document-parallel-funnel-delay branch May 29, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants