Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delegate wallet passthrough #334

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

acedward
Copy link
Contributor

        delegate                = &wd|from?|to?|from_signature|to_signature
        migrate                 = &wm|from?|to?|from_signature|to_signature
        cancelDelegate          = &wc|to_signature

if valid wallet-delegate commands are now passed to the SFT.
Valid means the signatures are correct, and the command could be processed and was not rejected.

Comment on lines +433 to +438
const sqlQueries = await gameStateTransition(
inputData,
latestChainData.blockNumber,
randomnessGenerator,
DBConn
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the user's STF doesn't have something to parse this? What happens if the name conflicts with something else the user defined in their STF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If the user does not have the parser setup, a console error will show up, but not halt paima-engine. (same error if a user posts any invalid command directly to the blockchain)

  2. Conflict is unlikely as the command starts with the symbol & as described in the documentation.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this may be a bit messy until we make STF failure more local instead of failing full txs, but we don't need to block this PR on that

@SebastienGllmt SebastienGllmt merged commit 0e713e5 into master Mar 31, 2024
@SebastienGllmt SebastienGllmt deleted the feature/delegate-wallet-passthrough branch March 31, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants