Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App has Depreciated member 'showSnackBar' and Non Responsive API . #77

Closed
i-anuragmishra opened this issue Mar 9, 2021 · 13 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@i-anuragmishra
Copy link
Contributor

i-anuragmishra commented Mar 9, 2021

The app contains many Depreciated members and API which needs to be replaced as they are depreciated and no longer supported in flutter. i would like to work on this @palisadoes @Deandrew007 . Can you assign me this issue.

@i-anuragmishra
Copy link
Contributor Author

The issue also mentions the Dedicated and non responsive API. which #78 does not resolve so i think still need to wait for maintainers to comment.

@i-anuragmishra i-anuragmishra changed the title App has Depreciated member 'showSnackBar'. Needs to be replaced App has Depreciated member 'showSnackBar' and Non Responsive API . Needs to be replaced Mar 10, 2021
@i-anuragmishra i-anuragmishra changed the title App has Depreciated member 'showSnackBar' and Non Responsive API . Needs to be replaced App has Depreciated member 'showSnackBar' and Non Responsive API . Mar 10, 2021
@jordanliu jordanliu added good first issue Good for newcomers bug Something isn't working labels Mar 11, 2021
@i-anuragmishra
Copy link
Contributor Author

i-anuragmishra commented Mar 11, 2021

Hey @jordanliu since i opened it and the PR mentioned doesn't fixes it properly or is not made according to open source contribution guidelines
can this issue be please assigned to me?

@Raunakk02
Copy link
Contributor

Hey! I would like to work on this issue. Can you please assign this issue to me?

@i-anuragmishra
Copy link
Contributor Author

hey @Raunakk02 please look at the above comments and follow guidelines for contribution. This issue has been created by me and the as regular SOP i have already asked the maintainers for assignment . Please look into #94 for the Contributing Guideline. Also there is a existing PR regarding this.

@Raunakk02
Copy link
Contributor

Raunakk02 commented Mar 13, 2021

Sure @i-anuragmishra, I asked to assign this issue to me because I was working on this earlier. But I think I will now wait for the PR to be merged first.

@DeltaHarbinger
Copy link
Contributor

@i-anuragmishra sorry for the long wait. this issue has now been assigned to you

@DeltaHarbinger
Copy link
Contributor

I see that you made some PRs related to this issue @i-anuragmishra, but they have merge conflicts with other PRs that were merged. Please pull the new changes in master and reimplement yours so they can be merged

@i-anuragmishra
Copy link
Contributor Author

@i-anuragmishra sorry for the long wait. this issue has now been assigned to you

Thanks a lot @DeltaHarbinger and no issues 😄...

@i-anuragmishra
Copy link
Contributor Author

I see that you made some PRs related to this issue @i-anuragmishra, but they have merge conflicts with other PRs that were merged. Please pull the new changes in master and reimplement yours so they can be merged

Okay @DeltaHarbinger will do... 👍

@DeltaHarbinger
Copy link
Contributor

Hey @i-anuragmishra, #76 also references this issue. I'll be redirecting the creator to this thread for further discussion on the topic

@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@Sagar2366 Sagar2366 added the hold label Mar 23, 2021
@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 24, 2021
@palisadoes
Copy link
Contributor

@i-anuragmishra The code freeze has been lifted please proceed with this. We have refactored the code, so you will need to fetch and merge with the upstream repo

@i-anuragmishra
Copy link
Contributor Author

i-anuragmishra commented Apr 24, 2021

Okay @palisadoes will do. Can you assign it to me please. Thanks

@CyberWake
Copy link
Contributor

@i-anuragmishra thanks for showing your concern as we are already migrating the codebase to flutter 2.0 and upgrading the dependencies this issue needs to be closed #834 .
@palisadoes sir we can close this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants