Skip to content

Commit

Permalink
Set default of PUBLIC_URL to /build to align with createReactApp buil…
Browse files Browse the repository at this point in the history
…d folder
  • Loading branch information
bmsuseluda committed Jun 30, 2021
1 parent 4662276 commit e2d2cd6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
REACT_APP_RADAR_NAME=AOE Technology Radar
PUBLIC_URL=/techradar
PUBLIC_URL=/build
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ The AOE Tech radar is deployed here: https://www.aoe.com/techradar/index.html

## Usage for your own radar?
The generator is free to use under Open Source License - in fact there are already some other Radars published based on our Radar and there are also Contributions back.
(There is a list of planned features below in case someone wants to contribute :-)

However, please be aware:

Expand All @@ -22,7 +21,7 @@ You can customize the following parts of the tech radar.
Set the environment variable `REACT_APP_RADAR_NAME`. The default is "AOE Technology Radar".

### Host the application under a sub path
To host the application under a sub path, set the environment variable `PUBLIC_URL`, e.g. "/techradar". The default is "/techradar".
To host the application under a sub path, set the environment variable `PUBLIC_URL`, e.g. "/techradar". The default is "/build".

### Change the favicon
To change the favicon, create a public folder in your application and put your favicon.ico in it.
Expand Down Expand Up @@ -58,7 +57,7 @@ Serve
python3 -m http.server 8080
```

Then open here: http://localhost:8080*PUBLIC_URL*
Then open here: http://localhost:8080/build

### Run a prepared static version
To have a better SEO ranking, you can generate a html file for every page.
Expand Down
6 changes: 3 additions & 3 deletions src/components/PageHelp/PageHelp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ export default function PageHelp({
more-informed and better-aligned decisions.
</p>
<p>
We also hope that developers outside of AOE find the informations in
our technologie overview inspirational.
We also hope that developers outside of AOE find the information in
our technology overview inspirational.
</p>
<p>
We group or categorize the items in 4 quadrants - (sometimes, when
Expand All @@ -81,7 +81,7 @@ export default function PageHelp({
<strong>Languages and Frameworks:</strong> We've placed development
languages (such as Scala or Golang) here, as well as more low-level
development frameworks (such as Play or Symfony), which are useful
for implementing custom software of all kinds.{" "}
for implementing custom software of all kinds.
</li>
<li>
<strong>Tools:</strong> Here we put different software tools - from
Expand Down

0 comments on commit e2d2cd6

Please sign in to comment.