Expand out datapack API #10828
Merged
Expand out datapack API #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
feature/expand-datapack-api
branch
4 times, most recently
from
80b202a
to
048084f
Compare
lynxplay
force-pushed
the
feature/expand-datapack-api
branch
from
048084f
to
c1e88ce
Compare
Machine-Maker
force-pushed
the
feature/expand-datapack-api
branch
from
c1e88ce
to
0064bda
Compare
lynxplay
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand out the datapack API with more functionality.
I think the WeakReference is the way to go with Pack references? Those are re-created everytime the PackRespository refreshes which can happen a lot, so holding onto them isn't ideal (like upstream's datapack implementation does).