Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MC-99601: Async gameprofile fetching in GameProfileArgument #11155

Closed
wants to merge 6 commits into from

Conversation

EpicPlayerA10
Copy link
Contributor

Fixes lag when fetching gameprofile in commands, like /whitelist add, /whitelist remove /ban, /op etc. Adds async gameprofile fetching in GameProfileArgument.

See https://bugs.mojang.com/browse/MC-99601

@EpicPlayerA10 EpicPlayerA10 requested a review from a team as a code owner July 23, 2024 16:40
@electronicboy
Copy link
Member

I think that there was generally some long term concerns over toying with some of this stuff due to stuff potentially expecting mutation to occur during execution, though, in part, we did discuss doing it lower so that it impacted stuff like API, etc

MinecraftServer is also an executor, and so you can use thanAcceptAsync

@lynxplay
Copy link
Contributor

After some more time and feedback from the team, I'll be closing this as a wont-merge.
Still thank you for your time and the objectively great work on the PR, even if the concept is something we do not feel comfortable merging.

The main reason for closing this is the potential reliance of this from third-party tools or plugins.
They may invoke these commands and simply rely on the fact that it happens instantly.

Given that third party plugins can 100% implement this PR in custom commands that would allow server owners to enjoy a lag-free whitelist/ban call without interfering with the vanilla behaviour here adds to the above reason.

I hope this makes sense to you, and again, thank you for the work, it is greatly appreciated even if we decided to not go forward with it. If you do end up developing this as a plugin or the likes, feel 100% free to link it here for others in need to find.

@lynxplay lynxplay closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants