Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Bukkit Command when wrapping CommandNodes #11385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cache Bukkit Command when wrapping CommandNodes #11385

wants to merge 1 commit into from

Commits on Sep 9, 2024

  1. Cache Bukkit Command when wrapping CommandNodes 

    Resolves PaperMC#11378 by "restoring" the Spigot behavior where VanillaCommandNodes are only created once. This allows command frameworks that insert CommandNodes directly into the Brigadier dispatcher to change the permission String of the VanillaCommandNodes created for their commands, rather than it always being the default `"minecraft.commands.<name>"`.

Previously, BukkitBrigForwardingMap would create a new VanillaCommandWrapper each time a CommandNode was requested via the Bukkit CommandMap. This means that calls to `Command#setPermission` would not persist between retrievals from the map.
    @willkroboth
    willkroboth committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5bb8a2e View commit details
    Browse the repository at this point in the history